Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed send_data method for WebSocket #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

P0W
Copy link

@P0W P0W commented Aug 8, 2023

  • The on_open method of underlying websocket object is already updated in connect method, not sure why currently send_data also updates it.

  • The send_data method updates the on_open method of underlying websocket object, instead it should allow user to send data over websocket.

  • This fix is needed to gracefully unsubscribe from the live stream feed, on an already existing websocket connection, after we create a payload from Request_Feed method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants